[PATCH] D79242: [MLIR] add dependencies for all tablegen targets on 'mlir-headers'

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer marked an inline comment as done.
stephenneuendorffer added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LoopOps/CMakeLists.txt:7
 add_public_tablegen_target(MLIRLoopPassIncGen)
+add_dependencies(mlir-headers MLIRLoopPassIncGen)
 
----------------
rriddle wrote:
> Wonder if it would be easier to just have our own `add_public_mlir_tablegen_target` that does this automatically.
Yes there's some further refactoring that can happen on the tablegen rules.  Probably adding add_mlir_interface is low-hanging fruit.  I think we can do this later, however.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79242/new/

https://reviews.llvm.org/D79242