[PATCH] D79165: [DebugInfo] - DWARFDebugFrame: do not call abort() on errors.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugFrame.cpp:412-415
+            return make_error<StringError>(
+                "Unknown augmentation character in entry at 0x" +
+                    Twine::utohexstr(StartOffset),
+                inconvertibleErrorCode());
----------------
jhenderson wrote:
> `createStringError` I think would be better?
> 
> `createStringError` would also allow this to change back to PRIx64, if I'm not mistaken.
> 
> Also, `inconvertibleErrorCode()` should probably be replaced with something else, probably `invalid_argument`.
Maybe we can de-capitalize the diagnostic by the way.

`createStringError(errc::invalid_argument, "unknown augmentation character in entry at 0x" PRIx64, ...)`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79165/new/

https://reviews.llvm.org/D79165