[PATCH] D79267: [RISCV][NFC] Add Test for (select (or B1, B2), X, Y)

[Luís Marques via Phabricator via llvm-commits]

luismarques added a comment.

LGTM.



================
Comment at: llvm/test/CodeGen/RISCV/select-or.ll:7-8
+
+;; This tests that we don't unneccessarily introduce too many selects, where we
+;; could instead do more complex logic before a single select.
+
----------------
Nit: if the codegen improvement isn't expected to be merged quickly then consider writing something more generic like "illustrates whether we use conditional jumps or additional logic", since for now it might be a bit confusing that the test does generate several branches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79267/new/

https://reviews.llvm.org/D79267