[PATCH] D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 17:17:47 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:138
+# RUN: llvm-objcopy -O binary %t4 %t4.out
+# RUN: od -A x -t x1 %t4.out | FileCheck %s --check-prefix=CHECK4 --ignore-case
+# RUN: wc -c %t4.out | FileCheck %s --check-prefix=SIZE4
----------------
jhenderson wrote:
> MaskRay wrote:
> > jhenderson wrote:
> > > Why --ignore-case?
> > https://reviews.llvm.org/D68693#2013750
> Thanks. Evidently I forgot that.
> 
> Bizarre that this tool somehow is so inconsistent in behaviour compared to other simialr tools (see also problems I've had before with argument ordering).
I would use only 0-9 and omit `--ignore-case`

```
# RUN: yaml2obj --docnum=6 %s -o %t6
# RUN: llvm-objcopy -O binary %t6 %t6.out
# RUN: od -A x -t x1 %t6.out | FileCheck %s --check-prefix=GNUSTACK

# GNUSTACK:      000000 90 90
# GNUSTACK-NEXT: 000002
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79038/new/

https://reviews.llvm.org/D79038





More information about the llvm-commits mailing list