[PATCH] D76711: [AArch64][SVE] Add some integer DestructiveBinaryComm* patterns

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

Thanks for the patch @cameron.mcinally, LGTM with one nit.

As we previously discussed offline, this design will need a rethink at some point because it is a bit rigid and it could be generalized to handle more cases than zeroing predication. However we can leave that for later.



================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:2349
+                                   DestructiveInstTypeEnum flags,
+                                   string revname="", bit isOrig=0> {
+  let DestructiveInstType = flags in {
----------------
nit: `isOrig` is a bit of a misnomer. Would `isReverse` maybe be more descriptive? (which would have the opposite meaning of `isOrig`)



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76711/new/

https://reviews.llvm.org/D76711