[PATCH] D79229: [llvm-objcopy] -O binary: skip empty sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:138
+# RUN: od -A x -t x2 %t4.out | FileCheck %s --check-prefix=SKIP-EMPTY
+# SKIP-EMPTY:      000000 3232
+# SKIP-EMPTY-NEXT: 000002
----------------
jhenderson wrote:
> Nit: I'd find it clearer if there was a blank line after the RUN lines before the SKIP-EMPTY lines.
> 
> Aside: I'm slightly surprised this works, given that -EMPTY is also a FileCheck suffix!
Switched to SKIPEMPTY.

The `-EMPTY` -DAG` arguments may suggest that we probably should prefer `FOO_BAR` to `FOO-BAR`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79229/new/

https://reviews.llvm.org/D79229