[PATCH] D79242: [MLIR] add dependencies for all tablegen targets on 'mlir-headers'

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Analysis/CMakeLists.txt:5
   CallGraph.cpp
-  Dominance.cpp
   Liveness.cpp
----------------
These changes seem like they should be in the other revision?


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp:14
 #include "PassDetail.h"
-#include "mlir/Analysis/Dominance.h"
+#include "mlir/IR/Dominance.h"
 #include "mlir/Dialect/Linalg/Analysis/DependenceAnalysis.h"
----------------
rriddle wrote:
> Were some of these changes supposed to be in the other revision?
Still unresolved?


================
Comment at: mlir/test/lib/Transforms/TestDominance.cpp:15
 
-#include "mlir/Analysis/Dominance.h"
+#include "mlir/IR/Dominance.h"
 #include "mlir/Pass/Pass.h"
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79242/new/

https://reviews.llvm.org/D79242