[PATCH] D68233: [FPEnv] [WIP] Verify strictfp attribute correctness

Kit Barton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 17:15:37 PDT 2020


kbarton added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:359
     verifySiblingFuncletUnwinds();
+    verifyFunctionConstrainedFP(F);
     InstsInThisBlock.clear();
----------------
I don't know how the traversal is done, but is this something that could be done inside visitFunction instead? 
That would require all of the instructions have been traversed at that point, and all the intrinsics have been visited, and I'm not sure whether that happens before or ofter visitFunction is called. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68233/new/

https://reviews.llvm.org/D68233





More information about the llvm-commits mailing list