[PATCH] D79242: [MLIR] add dependencies for all tablegen targets on 'mlir-headers'

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LoopOps/CMakeLists.txt:7
 add_public_tablegen_target(MLIRLoopPassIncGen)
+add_dependencies(mlir-headers MLIRLoopPassIncGen)
 
----------------
Wonder if it would be easier to just have our own `add_public_mlir_tablegen_target` that does this automatically.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Fusion.cpp:14
 #include "PassDetail.h"
-#include "mlir/Analysis/Dominance.h"
+#include "mlir/IR/Dominance.h"
 #include "mlir/Dialect/Linalg/Analysis/DependenceAnalysis.h"
----------------
Were some of these changes supposed to be in the other revision?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79242/new/

https://reviews.llvm.org/D79242