[PATCH] D79067: [MLIR] Fix libMLIR.so and LLVM_LINK_LLVM_DYLIB
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 1 17:15:13 PDT 2020
rriddle marked 2 inline comments as done.
rriddle added inline comments.
================
Comment at: mlir/cmake/modules/AddMLIR.cmake:156
+
+
+# Verification tools to aid debugging.
----------------
nit: Remove the new line here.
================
Comment at: mlir/examples/toy/Ch6/CMakeLists.txt:7
Support
+ nativecodegen
+ OrcJIT
----------------
Wonder why this name doesn't match the naming scheme of everything else...
================
Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:12
+ EXCLUDE_FROM_LIBMLIR
+
----------------
Maybe we should add a comment when using this?
================
Comment at: mlir/lib/Target/CMakeLists.txt:85
intrinsics_gen
+ LINK_COMPONENTS
+ Core
----------------
nit: Add a newline before this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79067/new/
https://reviews.llvm.org/D79067
More information about the llvm-commits
mailing list