[PATCH] D79240: [MLIR] Move Verifier and Dominance Analysis from /Analysis to /IR

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 17:15:08 PDT 2020


rriddle requested changes to this revision.
rriddle added a comment.
This revision now requires changes to proceed.

The files are marked as being added, but I would have expected something to mark the original locations as being moved/deleted.



================
Comment at: mlir/examples/toy/Ch2/mlir/MLIRGen.cpp:18
 
-#include "mlir/Analysis/Verifier.h"
+#include "mlir/IR/Verifier.h"
 #include "mlir/IR/Attributes.h"
----------------
Can you fix these include orderings now? I would expect a run of clang-format to handle it.


================
Comment at: mlir/include/mlir/IR/Dominance.h:9
+
+#ifndef MLIR_ANALYSIS_DOMINANCE_H
+#define MLIR_ANALYSIS_DOMINANCE_H
----------------
MLIR_IR_ Now


================
Comment at: mlir/include/mlir/IR/Verifier.h:9
+
+#ifndef MLIR_ANALYSIS_VERIFIER_H
+#define MLIR_ANALYSIS_VERIFIER_H
----------------
MLIR_IR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79240/new/

https://reviews.llvm.org/D79240





More information about the llvm-commits mailing list