[PATCH] D79221: Descriptive symbol names for machine basic block sections

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish marked 3 inline comments as done.
snehasish added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:87
+      if (SectionID == MBBSectionID::ColdSectionID) {
+        Suffix += ".cold";
+      } else if (SectionID == MBBSectionID::ExceptionSectionID) {
----------------
tmsriram wrote:
> Just a comment: I like this because it will demangle as expected and works well with existing symbolizers, profilers and debuggers out of the box.  
> 
> $ c++filt _Z3foov.cold
> foo() [clone .cold]
> 
> $ c++filt _Z3foov.eh
> foo() [clone .eh]
> 
> $c++filt _Z3foov.1234
> foo() [clone 1234]
> 
Good point, added this to the differential description. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79221/new/

https://reviews.llvm.org/D79221