[PATCH] D79207: [AArch64][GlobalISel] Use the IR pointer type in MMO to guess G_LOAD regbanks
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 1 17:14:46 PDT 2020
aemerson marked an inline comment as done.
aemerson added inline comments.
================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterBankInfo.cpp:689-690
+ if (LdVal) {
+ PointerType *PTy = cast<PointerType>(LdVal->getType());
+ if (PTy->getElementType()->isFPOrFPVectorTy()) {
OpRegBankIdx[0] = PMI_FirstFPR;
----------------
arsenm wrote:
> This is going to break opaque pointers
Indeed opaque pointers will break this. Which is why I was going to propose some other form of propagating type information on vregs. RFC incoming...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79207/new/
https://reviews.llvm.org/D79207
More information about the llvm-commits
mailing list