[PATCH] D79200: [DebugInfo] Update loop metadata in stripNonLineTableDebugInfo

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 17:14:44 PDT 2020


vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: llvm/lib/IR/DebugInfo.cpp:664
+          return remapDebugLoc(&Loc).get();
+        });
       }
----------------
aprantl wrote:
> Should we keep a form of the old loop and assert that no other DILocations are hanging off not-yet-handled future metadata?
There's a couple places where we'd need to add that assert, so I tried adding a verifier check instead (https://reviews.llvm.org/D79245). If you'd rather we just add a simple assert here that's fine too, lmk what you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79200/new/

https://reviews.llvm.org/D79200





More information about the llvm-commits mailing list