[PATCH] D78679: [LoopFusion] Fix LI after fusion of guarded loops

Fri May 1 17:13:35 PDT 2020

kbarton requested changes to this revision.
kbarton added a comment.
This revision now requires changes to proceed.

Hi Diego,
Thank you for submitting this patch!
I think this fix makes sense. If you could go ahead and add the check rules for the test cases that would be great!

To answer your question about only fusing loops in canonical form, I had started a patch in early March that would do exactly that (as well as a bunch of refactoring). Unfortunately I haven't been able to get back to it recently. This patch should work with those changes though, and the test cases will be a welcome addition to the testing to make sure nothing regresses. Thanks again for finding this and posting  a fix!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78679/new/

https://reviews.llvm.org/D78679