[llvm] dda0059 - [AIX] Skip unsupported ORC JIT RemoteObjectLayerTest on AIX

[David Tenty via llvm-commits]

Author: David Tenty
Date: 2020-05-01T17:03:05-04:00
New Revision: dda0059f95b04e0f03384db751a963206c98a185

URL: https://github.com/llvm/llvm-project/commit/dda0059f95b04e0f03384db751a963206c98a185
DIFF: https://github.com/llvm/llvm-project/commit/dda0059f95b04e0f03384db751a963206c98a185.diff

LOG: [AIX] Skip unsupported ORC JIT RemoteObjectLayerTest on AIX

Summary:
Currently the XCOFF backend does not support writing 64-bit object
files, which the ORC JIT tests will try to exercise if we are on AIX. This patch
selectively disables the tests on AIX for now.

Reviewers: hubert.reinterpretcast, jasonliu, DiggerLin, stevewan, lhames

Reviewed By: hubert.reinterpretcast, lhames

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78813

Added: 
    

Modified: 
    llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp b/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
index 31a4247e27d0..f25ddbbe155a 100644
--- a/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/RemoteObjectLayerTest.cpp
@@ -16,6 +16,19 @@
 using namespace llvm;
 using namespace llvm::orc;
 
+// Writing 64-bit XCOFF isn't supported yet, so we need to disable some tests on
+// AIX till it is.
+#ifdef _AIX
+#define SKIPTEST_IF_UNSUPPORTED()                                              \
+  do {                                                                         \
+    return;                                                                    \
+  } while (false)
+#else
+#define SKIPTEST_IF_UNSUPPORTED()                                              \
+  do {                                                                         \
+  } while (false)
+#endif
+
 namespace {
 
 class MockObjectLayer {
@@ -109,6 +122,7 @@ MockObjectLayer::ObjectPtr createTestObject() {
 }
 
 TEST(RemoteObjectLayer, AddObject) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)
@@ -166,6 +180,7 @@ TEST(RemoteObjectLayer, AddObject) {
 }
 
 TEST(RemoteObjectLayer, AddObjectFailure) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)
@@ -221,6 +236,7 @@ TEST(RemoteObjectLayer, AddObjectFailure) {
 
 
 TEST(RemoteObjectLayer, RemoveObject) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)
@@ -268,6 +284,7 @@ TEST(RemoteObjectLayer, RemoveObject) {
 }
 
 TEST(RemoteObjectLayer, RemoveObjectFailure) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)
@@ -324,6 +341,7 @@ TEST(RemoteObjectLayer, RemoveObjectFailure) {
 }
 
 TEST(RemoteObjectLayer, FindSymbol) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)
@@ -406,6 +424,7 @@ TEST(RemoteObjectLayer, FindSymbol) {
 }
 
 TEST(RemoteObjectLayer, FindSymbolIn) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)
@@ -484,6 +503,7 @@ TEST(RemoteObjectLayer, FindSymbolIn) {
 }
 
 TEST(RemoteObjectLayer, EmitAndFinalize) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)
@@ -532,6 +552,7 @@ TEST(RemoteObjectLayer, EmitAndFinalize) {
 }
 
 TEST(RemoteObjectLayer, EmitAndFinalizeFailure) {
+  SKIPTEST_IF_UNSUPPORTED();
   llvm::orc::rpc::registerStringError<rpc::RawByteChannel>();
   auto TestObject = createTestObject();
   if (!TestObject)