[PATCH] D68231: [SLC] Allow llvm.pow(x,2.0) -> x*x etc even if no pow() lib func

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 08:16:02 PDT 2020


spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/pow-3.ll:9
 
 define double @test_simplify_unavailable1(double %x) {
 ; CHECK-LABEL: @test_simplify_unavailable1(
----------------
Please update/rebase - I added a test to cover the case that I assume was intended:
rG5013a788f8e


================
Comment at: llvm/test/Transforms/InstCombine/pow-amdgcn.ll:1
+; RUN: opt < %s -mtriple=amdgcn-- -targetlibinfo -instcombine -S | FileCheck %s
+
----------------
Can you add a RUN line for this to the existing "pow-1.ll" test file instead of adding a new test file? The existing file is already used to test various target combos.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68231/new/

https://reviews.llvm.org/D68231





More information about the llvm-commits mailing list