[PATCH] D74122: [CallSiteInfo] Use the isCandidateForCallSiteEntry() when update the cs info

[Momchil Velikov via Phabricator via llvm-commits]

chill added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1210
       // Update call site info and delete the pseudo instruction TCRETURN.
-      MBB.getParent()->moveCallSiteInfo(&MI, &*NewMI);
+      if (MI.isCandidateForCallSiteEntry())
+        MI.getMF()->moveCallSiteInfo(&MI, &*NewMI);
----------------
Isn't this check redundant, give we know we're replacing a `TCRETURNxxx` ?


================
Comment at: llvm/lib/Target/ARM/ARMExpandPseudoInsts.cpp:1445
+      // Update the call site info.
+      if (MI.isCandidateForCallSiteEntry())
+        MF->moveCallSiteInfo(&MI, &*MIB);
----------------
Likewise, isn't this redundant, given we have `TPsoft`/`tTPsoft`, both of which have `isCall = 1`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74122/new/

https://reviews.llvm.org/D74122