[PATCH] D79091: [mlir][spirv] Handle debug information during (de)serialization.

Denis Khalikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 04:06:37 PDT 2020


denis13 marked 2 inline comments as done.
denis13 added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp:71
 
+/// A strcut for containing OpLine instruction information.
+struct DebugLine {
----------------
aprantl wrote:
> struct
Thanks, fixed!


================
Comment at: mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp:77
+
+  DebugLine() : fileID(0), line(0), col(0) {}
+  DebugLine(uint32_t fileIDNum, uint32_t lineNum, uint32_t colNum)
----------------
antiagainst wrote:
> These constructors can be deleted too?
Thanks, fixed!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79091/new/

https://reviews.llvm.org/D79091





More information about the llvm-commits mailing list