[PATCH] D79229: [llvm-objcopy] -O binary: skip empty sections

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of nits.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:138
+# RUN: od -A x -t x2 %t4.out | FileCheck %s --check-prefix=SKIP-EMPTY
+# SKIP-EMPTY:      000000 3232
+# SKIP-EMPTY-NEXT: 000002
----------------
Nit: I'd find it clearer if there was a blank line after the RUN lines before the SKIP-EMPTY lines.

Aside: I'm slightly surprised this works, given that -EMPTY is also a FileCheck suffix!


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:177
+# RUN: od -A x -t x2 %t5.out | FileCheck %s --check-prefix=SKIP-EMPTY
+--- !ELF
+FileHeader:
----------------
Nit: blank line before this line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79229/new/

https://reviews.llvm.org/D79229