[PATCH] D79038: [objdump][ELF] Handle sections not contained in PT_LOAD segments

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Latest version LGTM, with one comment nit.



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:138
+# RUN: llvm-objcopy -O binary %t4 %t4.out
+# RUN: od -A x -t x1 %t4.out | FileCheck %s --check-prefix=CHECK4 --ignore-case
+# RUN: wc -c %t4.out | FileCheck %s --check-prefix=SIZE4
----------------
MaskRay wrote:
> jhenderson wrote:
> > Why --ignore-case?
> https://reviews.llvm.org/D68693#2013750
Thanks. Evidently I forgot that.

Bizarre that this tool somehow is so inconsistent in behaviour compared to other simialr tools (see also problems I've had before with argument ordering).


================
Comment at: llvm/tools/llvm-objcopy/ELF/Object.cpp:1068
 
+  // Skip PT_GNU_STACK segments, they only exist to define the stack
+  // executability and its size and don't refer to a real memory area.
----------------
"segments, they" -> either "segments. They" or "segments: they"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79038/new/

https://reviews.llvm.org/D79038