[PATCH] D79187: [DAGCombiner] fold (fp_round (int_to_fp X)) -> (int_to_fp X)

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 02:02:17 PDT 2020


lenary added a comment.

Thanks for all the help, I will add the `hasOperation(...)` check to the fold.

I'm not convinced I'm using the semanticsPrecision from the correct node - I think perhaps I should be using the precision of the final resulting type of the `fp_round`. Once I've made the `hasOperation` change, I'll check this potential change against the AArch64 tests again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79187/new/

https://reviews.llvm.org/D79187





More information about the llvm-commits mailing list