[PATCH] D79093: [DebugInfo] Fix printing values of forms which depend on the DWARF format.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFFormValueTest.cpp:375-380
+    testing::Values(DumpValueParams{DW_FORM_strp, 0x1122334455667788,
+                                    " .debug_str[0x1122334455667788] = "},
+                    DumpValueParams{DW_FORM_line_strp, 0x1122334455667788,
+                                    " .debug_line_str[0x1122334455667788] = "},
+                    DumpValueParams{DW_FORM_sec_offset, 0x1122334455667788,
+                                    "0x1122334455667788"}), );
----------------
It might be worth adding a test case where not all 16 digits are produced, to show that we don't print leading zeroes.

Also, is it worth DWARF32 test cases? Not sure, and maybe not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79093/new/

https://reviews.llvm.org/D79093