[PATCH] D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 1 01:42:52 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/include/llvm/MC/MCContext.h:104
 
+    /// llvm extern intrinsic xcoff symbols used for emiting these symbol's
+    /// linkage.
----------------
Nit: symbol's -> symbols' (or if you don't like that, try "the linkage of these symbols.")

I would write emiting as emitting, but I don't know if that's a British versus American English thing.

Here and in other comments, should "llvm" be "LLVM"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78929/new/

https://reviews.llvm.org/D78929





More information about the llvm-commits mailing list