[PATCH] D79092: [Flang][Driver]Add new flang driver main() entrypoint

[Caroline via Phabricator via llvm-commits]

CarolineConcatto added a comment.

@sscalpone can you tell us what is your concern? It is compiling time now that the driver is not fully functional?

If it is compiling time, what I can do to save compiler time while the driver is not functional is do the same as FIR by using a similar CMake variable as LINK_WITH_FIR.

I could create a variable for the driver, that we would only build it with clang dependencies when we want to build the new driver.

Now, if the problem is linking the driver with Clang than I agree with @awarzynski and this is a problem that we may be able to solve later in this project.



================
Comment at: flang/CMakeLists.txt:246
 # Add global F18 flags.
-set(CMAKE_CXX_FLAGS "-fno-rtti -fno-exceptions -pedantic -Wall -Wextra -Werror -Wcast-qual -Wimplicit-fallthrough -Wdelete-non-virtual-dtor ${CMAKE_CXX_FLAGS}")
+set(CMAKE_CXX_FLAGS "-fno-rtti -fno-exceptions -pedantic -Wall -Wextra -Wcast-qual -Wimplicit-fallthrough -Wdelete-non-virtual-dtor ${CMAKE_CXX_FLAGS}")
 
----------------
This is a mistake. The patch works with -Werror. I'll revert this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79092/new/

https://reviews.llvm.org/D79092