[PATCH] D78894: [ms] Add new option to llvm-lib: /llvmlibempty

Thu Apr 30 20:08:38 PDT 2020

epastor added a comment.

In D78894#2014407 <https://reviews.llvm.org/D78894#2014407>, @epastor wrote:

> In D78894#2014406 <https://reviews.llvm.org/D78894#2014406>, @epastor wrote:
>
> > In D78894#2014398 <https://reviews.llvm.org/D78894#2014398>, @vvereschaka wrote:
> >
> > > Hi Eric,
> > >
> > > the updated `no-inputs.test` test gets crashed on `llvm-clang-x86_64-expensive-checks-ubuntu` builder.
> > >  http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/5166
> >
> >
> > I believe this is already fixed in https://reviews.llvm.org/rG291d24838fcf
>
>
> Hm. It doesn't seem to be fixed, but I don't see why not. I can't replicate this crash on my local machine. Can you give any more information that would help me reproduce this?

Nevermind, I see a potential problem. If neither an output nor an input is provided, we can end up indexing into an uninitialized spot in the Members vector. I'll post a patch that fixes that ASAP, and send it to you and Nico for review - I'll submit it once I get approval.

However... that's not true with these tests, and they're passing on all the other buildbots. Is there maybe a problem with this buildbot and parameters like `-out:<value>`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78894/new/

https://reviews.llvm.org/D78894