[PATCH] D79226: [lld-macho] Use export trie instead of symtab when linking against dylibs

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
int3 added reviewers: ruiu, pcc, MaskRay, smeenai, alexshap, gkm, Ktwu, christylee.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

This allows us to link against stripped dylibs. Moreover, it's simply
more correct: The symbol table includes symbols that the dylib uses but
doesn't export.

This temporarily regresses our ability to do lazy symbol binding because
dyld_stub_binder isn't in libSystem's export trie. Rather, it is in one
of the sub-libraries libSystem re-exports. (This doesn't affect our
tests since we are mocking out dyld_stub_binder there.) A follow-up diff
will address this by adding support for sub-libraries.

Depends on D79114 <https://reviews.llvm.org/D79114>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79226

Files:
  lld/MachO/ExportTrie.cpp
  lld/MachO/ExportTrie.h
  lld/MachO/InputFiles.cpp
  lld/test/CMakeLists.txt
  lld/test/MachO/dylink.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79226.261423.patch
Type: text/x-patch
Size: 5274 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200501/e58cb9fe/attachment.bin>