[PATCH] D79019: [mlir][llvm] allow mlir-translate carry custom triple and data layout.

[Wen-Heng (Jack) Chung via Phabricator via llvm-commits]

whchung added a comment.

>>> Right now I see this as implementing something deliberately incorrect.
>> 
>> The flow we already have is also incorrect. I see this patch as less problematic as long as it does not claim it corrects the current flow.
>> 
>>> I am not opposed to taking shortcuts, but I'd like these to be clearly identified, for example there should be a tracking bug and big TODO statement:
>> 
>> Sure, we agree here, let's do this.
> 
> @whchung how does that sounds?

@mehdi_amini Agree. I've revised the patch so it has a TODO statement in the new interface. I'm applying for a new account on Bugzilla so if you could create one that would be very helpful.

@ftynse I agree with your assessment that data layout is best conveyed in std->llvm conversion process. I myself am seeing sub-optimal codes generated due to how `index` types get produced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79019/new/

https://reviews.llvm.org/D79019