[llvm] 70605ff - [lit] Don't crash for --time-tests in aborted test run

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 18:19:21 PDT 2020


Author: Julian Lettner
Date: 2020-04-30T18:19:15-07:00
New Revision: 70605ff452a8a45aa6924baff60bed14eb8fb00a

URL: https://github.com/llvm/llvm-project/commit/70605ff452a8a45aa6924baff60bed14eb8fb00a
DIFF: https://github.com/llvm/llvm-project/commit/70605ff452a8a45aa6924baff60bed14eb8fb00a.diff

LOG: [lit] Don't crash for --time-tests in aborted test run

Properly print the test times histogram even for aborted (user
interrupt, [Ctrl+C]) test runs.

Added: 
    

Modified: 
    llvm/utils/lit/lit/main.py

Removed: 
    


################################################################################
diff  --git a/llvm/utils/lit/lit/main.py b/llvm/utils/lit/lit/main.py
index 3f3b34aff15e..bbaeb0d6b34e 100755
--- a/llvm/utils/lit/lit/main.py
+++ b/llvm/utils/lit/lit/main.py
@@ -94,7 +94,7 @@ def main(builtin_params={}):
         t for t in selected_tests if t.result.code != lit.Test.SKIPPED]
 
     if opts.time_tests:
-        print_histogram(executed_tests)
+        print_histogram(discovered_tests)
 
     print_results(discovered_tests, elapsed, opts)
 
@@ -257,8 +257,10 @@ def execute_in_tmp_dir(run, lit_config):
 
 
 def print_histogram(tests):
-    test_times = [(t.getFullName(), t.result.elapsed) for t in tests]
-    lit.util.printHistogram(test_times, title='Tests')
+    test_times = [(t.getFullName(), t.result.elapsed)
+                  for t in tests if t.result.elapsed]
+    if test_times:
+        lit.util.printHistogram(test_times, title='Tests')
 
 
 def add_result_category(result_code, label):


        


More information about the llvm-commits mailing list