[PATCH] D79206: [mlir][OpBuilder] Remove the vtable from OpBuilder in favor of using the listener pattern

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Tiling.cpp:389
+    // FIXME: This should keep the same listener.
+    b.setListener(nullptr);
+
----------------
ftynse wrote:
> Could you please elaborate why this is necessary? There are other uses of GenericLoopNestRangeBuilder in LinalgToLoops that are not modified...
b is being copied, so wasn't previously notifying the PatterRewriter of any generated operations. One of the tests relied on this behavior and broke, but Nicolas removed that test so this can be removed now. This was the only builder that a test relied on for the old(incorrect) behavior, so it was the only one I updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79206/new/

https://reviews.llvm.org/D79206