[PATCH] D79143: [mlir][StandardToSPIRV] Add support for lowering integer casting.

[Han-Chung Wang via Phabricator via llvm-commits]

hanchung added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp:757
       TypeCastingOpPattern<SIToFPOp, spirv::ConvertSToFOp>,
+      TypeCastingOpPattern<ZeroExtendIOp, spirv::SConvertOp>,
+      TypeCastingOpPattern<TruncateIOp, spirv::SConvertOp>,
----------------
antiagainst wrote:
> Shouldn't we use UConvert here? 
good catch...thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79143/new/

https://reviews.llvm.org/D79143