[PATCH] D79212: [SVE] Remove invalid usage of getNumElements in Instructions
Christopher Tetreault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 30 15:06:52 PDT 2020
ctetreau created this revision.
Herald added subscribers: llvm-commits, psnobl, rkruppe, hiraditya, tschuett.
Herald added a reviewer: efriedma.
Herald added a project: LLVM.
ctetreau added reviewers: sdesmalen, c-rhodes, spatel.
ctetreau added a child revision: D79053: [SVE] Fix invalid uses of VectorType::getNumElements().
Remove invalid usage of VectorType::getNumElements in
ShuffleVectorInst::isValidOperands identified by test case
llvm::Analysis/ConstantFolding/vscale-shufflevector.ll. The tested
conditions hold for both fixed width and scalable vectors; use
getElementCount().
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D79212
Files:
llvm/lib/IR/Instructions.cpp
Index: llvm/lib/IR/Instructions.cpp
===================================================================
--- llvm/lib/IR/Instructions.cpp
+++ llvm/lib/IR/Instructions.cpp
@@ -1916,11 +1916,11 @@
bool ShuffleVectorInst::isValidOperands(const Value *V1, const Value *V2,
ArrayRef<int> Mask) {
// V1 and V2 must be vectors of the same type.
- if (!V1->getType()->isVectorTy() || V1->getType() != V2->getType())
+ if (!isa<VectorType>(V1->getType()) || V1->getType() != V2->getType())
return false;
// Make sure the mask elements make sense.
- int V1Size = cast<VectorType>(V1->getType())->getNumElements();
+ int V1Size = cast<VectorType>(V1->getType())->getElementCount().Min;
for (int Elem : Mask)
if (Elem != UndefMaskElem && Elem >= V1Size * 2)
return false;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79212.261366.patch
Type: text/x-patch
Size: 833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200430/a6920008/attachment.bin>
More information about the llvm-commits
mailing list