[PATCH] D79208: [mlir][EDSC] Make use of InsertGuard

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 15:06:45 PDT 2020


rriddle accepted this revision.
rriddle marked an inline comment as done.
rriddle added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/EDSC/Builders.cpp:86
+                                                   res.block->begin());
+  for (auto t : argTypes)
     res.block->addArgument(t);
----------------
You should be able to just do `res.block->addArguments(argTypes)`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79208/new/

https://reviews.llvm.org/D79208





More information about the llvm-commits mailing list