[PATCH] D79042: [llvm] Add interface to drive inlining decision using ML model

[Eric Christopher via llvm-commits]

On Thu, Apr 30, 2020 at 2:00 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added inline comments.
>
>
> ================
> Comment at: llvm/test/Transforms/Inline/inlining-advisor-default.ll:9
> +
> +; CHECK: Could not setup Inlining Advisor for the requested mode and/or
> options
> ----------------
> mtrofin wrote:
> > davidxl wrote:
> > > I wonder if it is useful to have a mock mode for testing purpose where
> the ML code is barebone but not fully statically compiled out.
> > If we only use that for test, then the 'dev' mode where we just capture
> logs does exactly that - and I plan on getting a build bot setup for this;
> and it has a test, of course (and doesn't add complexity)
> it might be better to exercise some tests by default (without relying on
> bot). When there is a breakage, it is also easier for folks to reproduce.
>
>
Agreed here FWIW :)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200430/70ea9773/attachment.html>