[PATCH] D79038: [objdump][ELF] Handle sections not contained in PT_LOAD segments
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 30 14:00:30 PDT 2020
MaskRay added a comment.
New code looks good to me.
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:138
+# RUN: llvm-objcopy -O binary %t4 %t4.out
+# RUN: od -A x -t x1 %t4.out | FileCheck %s --check-prefix=CHECK4 --ignore-case
+# RUN: wc -c %t4.out | FileCheck %s --check-prefix=SIZE4
----------------
jhenderson wrote:
> Why --ignore-case?
https://reviews.llvm.org/D68693#2013750
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:149
+ Type: ET_EXEC
+ Machine: EM_X86_64
+Sections:
----------------
Reduce indentation so that there is exactly one space after the longest key (`Machine:`)
================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:174
+ Align: 0x0000
+ # The huge size makes this phdr a parent of .bss
+ MemSize: 0x1000000
----------------
The comment is stale.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79038/new/
https://reviews.llvm.org/D79038
More information about the llvm-commits
mailing list