[PATCH] D79200: [DebugInfo] Update loop metadata in stripNonLineTableDebugInfo

[Vedant Kumar via Phabricator via llvm-commits]

vsk created this revision.
vsk added reviewers: aprantl, dsanders.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

Have stripNonLineTableDebugInfo() attach updated !llvm.loop metadata to
an instruction (instead of updating and then discarding the metadata).

This fixes "!dbg attachment points at wrong subprogram for function"
errors seen while archiving an iOS app.

It would be nice -- as a follow-up -- to catch this issue earlier,
perhaps by modifying the verifier to constrain where DILocations are
allowed. Any alternative suggestions appreciated.

rdar://61982466


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79200

Files:
  llvm/lib/IR/DebugInfo.cpp
  llvm/unittests/IR/DebugInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79200.261337.patch
Type: text/x-patch
Size: 4000 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200430/906b2c5d/attachment.bin>