[PATCH] D78672: [Debuginfo] Remove redundand variable from getAttributeValue()

[Alexey Lapshin via Phabricator via llvm-commits]

avl added a comment.

@clayborg

> If we did end up tracking FixedOffset values in each AttributeSpec, we could track index of the last AttributeSpec that has a fixed form size and keep it as an ivar to this class. This loop could become more efficient by skipping all of the fixed form sizes up front and then only iterating over the remaining ones:

I gave it a try. But it did not show any performance improvement. It even created a small(0.5%) performance degradation - https://reviews.llvm.org/differential/diff/261331/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78672/new/

https://reviews.llvm.org/D78672