[PATCH] D79005: [LLD][COFF] Move debug info for thread-local variables into PDB global stream

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lld/COFF/PDB.cpp:809
     return !isGlobalScope;
   // S_GDATA32 does not go in the module stream, but S_LDATA32 does.
   case SymbolKind::S_LDATA32:
----------------
S_LTHREAD32 doesn't follow this pattern? I was kind of expecting it to show up wherever S_LDATA32 is.


================
Comment at: lld/test/COFF/Inputs/pdb-globals.yaml:41
+#   // S_LTHREAD32
+#   thread_local int LocalThreadLocal = 45;
+#   N += LocalThreadLocal;
----------------
Huh, `static thread_local int` at global scope doesn't do it? And these don't show up in the PDB's global stream?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79005/new/

https://reviews.llvm.org/D79005