[PATCH] D79153: [lld-macho] Avoid unnecessary preprocessing of relocations
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 30 13:26:53 PDT 2020
int3 added a comment.
I *think* what ld64 does is to translate the raw relocation structures into "fixups" that target specific atoms / subsections. But it's still not clear to me that we can't do the relocation -> subsection mapping at output time. Moreover, given the current state of the implementation, I don't think having a separate Reloc struct is super useful -- all we're really doing is doing a 1:1 copy of various field values, plus the symbol/section resolution, and the latter can definitely be done at output time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79153/new/
https://reviews.llvm.org/D79153
More information about the llvm-commits
mailing list