[PATCH] D79028: [DebugInfo][CodeView] Include namespace into emitted globals

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:3146
     emitNullTerminatedSymbolName(OS,
                                  getFullyQualifiedName(Scope, DIGV->getName()));
     endSymbolRecord(SConstantEnd);
----------------
rnk wrote:
> Looks like @akhuang got this right recently for S_CONSTANT, but we've had the bug with global names since forever. :(
I've updated the code above a bit. There was an edge case with `S_LTHREAD32` which needed to emit a unscoped name. Could you please take a quick look again?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79028/new/

https://reviews.llvm.org/D79028