[PATCH] D79042: [llvm] Add interface to drive inlining decision using ML model

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D79042#2011802 <https://reviews.llvm.org/D79042#2011802>, @echristo wrote:

> This is pretty cool. I've got one high level question and then a few minor things in the patch.
>
> High level: Would it be better to split this out even more rather than the if/elses in the Inliner? i.e. rather than conditionalizing it just have N paths through. It may mean a little bit more duplicated or factored code, but would probably be a little easier to read through.
>
> Thoughts?
>
> -eric


I agree - I'll send first some NFC patches cleaning up a bit the current code; then, refactor along the lines you suggested. I think there'll end up being very little, if any, duplication, too!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79042/new/

https://reviews.llvm.org/D79042