[PATCH] D79143: [mlir][StandardToSPIRV] Add support for lowering integer casting.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst requested changes to this revision.
antiagainst added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/lib/Conversion/StandardToSPIRV/ConvertStandardToSPIRV.cpp:757
       TypeCastingOpPattern<SIToFPOp, spirv::ConvertSToFOp>,
+      TypeCastingOpPattern<ZeroExtendIOp, spirv::SConvertOp>,
+      TypeCastingOpPattern<TruncateIOp, spirv::SConvertOp>,
----------------
Shouldn't we use UConvert here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79143/new/

https://reviews.llvm.org/D79143