[PATCH] D78894: [ms] Add new option to llvm-lib: /llvmemptylib

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 11:47:17 PDT 2020


epastor added a comment.

In D78894#2013271 <https://reviews.llvm.org/D78894#2013271>, @thakis wrote:

> In D78894#2010852 <https://reviews.llvm.org/D78894#2010852>, @epastor wrote:
>
> > In D78894#2010440 <https://reviews.llvm.org/D78894#2010440>, @thakis wrote:
> >
> > > Thoughts on making this affect the export lib creation as well?
> >
> >
> > Might be a good idea, but it's a completely separate tool (since llvm-ar/llvm-lib has no overlap with lld). I'd suggest doing it as a followup commit, rather than as part of this... especially since this one is not a change to the default behavior, whereas the export lib creation would be a change to the default behavior.
>
>
> I mean the .lib written by link.exe when you link a .dll (cf /IMPLIB: https://docs.microsoft.com/en-us/cpp/build/reference/implib-name-import-library?view=vs-2019)


Right - but in these tools, that's written by lld-link, not llvm-lib... and there's no code overlap. And it would involve changing the default behavior of lld-link in a breaking fashion... so I'm suggesting that should go in a separate commit, probably with a quick RFC to the relevant lists.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78894/new/

https://reviews.llvm.org/D78894





More information about the llvm-commits mailing list