[PATCH] D79103: Fix ELF/linkerscript/input-archive.s w/ @ in path

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 10:08:32 PDT 2020


thopre updated this revision to Diff 261272.
thopre added a comment.

Use single quoting for linker script


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79103/new/

https://reviews.llvm.org/D79103

Files:
  lld/test/ELF/linkerscript/input-archive.s
  lld/test/ELF/linkerscript/thunk-gen-mips.s


Index: lld/test/ELF/linkerscript/thunk-gen-mips.s
===================================================================
--- lld/test/ELF/linkerscript/thunk-gen-mips.s
+++ lld/test/ELF/linkerscript/thunk-gen-mips.s
@@ -4,14 +4,14 @@
 
 # SECTIONS command with the first pattern that does not match.
 # Linking a PIC and non-PIC object files triggers the LA25 thunk generation.
-# RUN:		echo "SECTIONS { \
+# RUN:		echo 'SECTIONS { \
 # RUN:		.text : { \
 # RUN:			*(.nomatch) \
-# RUN:			%t(.text) \
+# RUN:			"%t"(.text) \
 # RUN:			. = . + 0x100000 ; \
-# RUN:			%t1(.text) \
+# RUN:			"%t1"(.text) \
 # RUN:		} \
-# RUN:	}" > %t.script
+# RUN:	}' > %t.script
 # RUN: ld.lld -o %t.exe --script %t.script %t %t1
 # RUN: llvm-objdump -t %t.exe | FileCheck %s
 # CHECK: SYMBOL TABLE:
Index: lld/test/ELF/linkerscript/input-archive.s
===================================================================
--- lld/test/ELF/linkerscript/input-archive.s
+++ lld/test/ELF/linkerscript/input-archive.s
@@ -11,7 +11,7 @@
 ## *.a:b.o matches /path/to/input-archive.s.tmp.a:b.o
 ## *b.o matches /path/to/input-archive.s.tmp.a:b.o
 # RUN: echo 'SECTIONS { \
-# RUN:   .foo : { %t.a:a.o(.data) } \
+# RUN:   .foo : { "%t.a:a.o"(.data) } \
 # RUN:   .bar : { *.a:b.o(.data) } \
 # RUN:   .qux : { *b.o(.data1) } \
 # RUN:   }' > %t.script


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79103.261272.patch
Type: text/x-patch
Size: 1320 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200430/56eca405/attachment.bin>


More information about the llvm-commits mailing list