[PATCH] D79136: [XCOFF] Clean-up enum use in BinaryFormat/XCOFF.h; NFC
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 30 09:35:49 PDT 2020
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:25
// Constants used in the XCOFF definition.
-enum {
- FileNamePadSize = 6,
- NameSize = 8,
- SymbolTableEntrySize = 18,
- RelocationSerializationSize32 = 10
-};
+constexpr size_t FileNamePadSize = 6;
----------------
jasonliu wrote:
> nit: remove blank line?
The blank line is intentional on my part. This comment describes more than just the immediate block of declarations.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79136/new/
https://reviews.llvm.org/D79136
More information about the llvm-commits
mailing list