[PATCH] D79173: [Debuginfo][NFC] Avoid double calling of DWARFDie::find(DW_AT_name).

Thu Apr 30 09:02:45 PDT 2020

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDie.cpp:529-542
 const char *DWARFDie::getName(DINameKind Kind) const {
   if (!isValid() || Kind == DINameKind::None)
     return nullptr;
   // Try to get mangled name only if it was asked for.
   if (Kind == DINameKind::LinkageName) {
-    if (auto Name = dwarf::toString(
-            findRecursively({DW_AT_MIPS_linkage_name, DW_AT_linkage_name}),
----------------
Are there any callers left relying on this fallback behavior? Could they be ported to an explicit function dedicated to this task ("getLinkageNameOrShortName") so it's clear?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79173/new/

https://reviews.llvm.org/D79173