[PATCH] D79091: [mlir][spirv] Handle debug information during (de)serialization.

[Denis Khalikov via Phabricator via llvm-commits]

denis13 marked an inline comment as done.
denis13 added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp:2021
+    return emitError(unknownLoc, "OpLine must have 3 operands");
+  debugLine = {operands.begin(), operands.end()};
+  return success();
----------------
antiagainst wrote:
> OpNoLine should kill this definition. Could you add a `process*` function for it? It should be trivial. :)
Thanks for review, if I got it right, we have to clear debug line in 3 cases:
1) end of block.
2) OpNoLine.
3) Another OpLine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79091/new/

https://reviews.llvm.org/D79091