[PATCH] D78107: [CSInfo][MIPS] Call delay slot support in DwarfDebug

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:859-860
+    // TODO: Add support for targets with delay slots (see: beginInstruction).
+    if (TT.isMIPS())
+      return true;
+    return false;
----------------
Do you know what would happen if you didn't have this guard, and enabled call site information for another target with delay slots?

If it is something that is relatively easy to catch, or perhaps not very serious, I think I'd prefer to have this code target-agnostic (i.e. just `MI.hasDelaySlot`), and just leave it up to the developer enabling call site information for the target to make sure that there are no delay slot quirks that need to be considered.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1873-1874
+    // TODO: Add support for targets with delay slots.
+    if (TT.isMIPS())
+      return true;
+    return false;
----------------
Same as above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78107/new/

https://reviews.llvm.org/D78107