[PATCH] D78793: Names for structs are held on the Context, not the Module. Move getTypeByName from Module to Type taking a Context parameter.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 06:12:57 PDT 2020


jdoerfert added a comment.

I think the new location is reasonable, I don't know about our C API policy though. Two questions below.



================
Comment at: llvm/include/llvm-c/Core.h:873
 
-/**
- * Obtain a Type from a module by its registered name.
- */
+/** Deprecated: Use LLVMGetTypeByName2 instead. */
 LLVMTypeRef LLVMGetTypeByName(LLVMModuleRef M, const char *Name);
----------------
1) Should we use the deprecated attribute here?
2) We cannot use attribute((overrload)) can we?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78793/new/

https://reviews.llvm.org/D78793





More information about the llvm-commits mailing list