[PATCH] D62485: New implementation of OpenMP 5.0 detached tasks.

Joachim Protze via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 30 05:16:50 PDT 2020


protze.joachim added a comment.
Herald added a subscriber: yaxunl.

In D62485#1550157 <https://reviews.llvm.org/D62485#1550157>, @hbae wrote:

> Joachim, do you have any specific OMPT callbacks in mind?
>  I don't think we have any callbacks to insert in the new code.


Sorry for the late reply.
Two changes are necessary:

- `__ompt_task_finish` should only set  `ompt_task_complete`, if the task is complete (probably move the call after the bit is updated). Otherwise `ompt_task_switch`should be used.
- The //task-fulfill// event needs implementation (see omp_fulfill_event).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62485/new/

https://reviews.llvm.org/D62485





More information about the llvm-commits mailing list